Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing keyboard doesn't account for multiple "Done" buttons #20

Open
ctrevarthen opened this issue Jul 29, 2019 · 0 comments
Open

Closing keyboard doesn't account for multiple "Done" buttons #20

ctrevarthen opened this issue Jul 29, 2019 · 0 comments
Labels
bug Something isn't working in progress This issue is being worked on currently ios This issue affects iOS

Comments

@ctrevarthen
Copy link
Contributor

There could be a "Done" button in the nav bar as well as the keyboard toolbar.

The current logic for closing the keyboard in iOS looks for buttons with text "OK", "SELECT", "Select", "DONE", or "Done". If we accidentally tap on the nav bar's "Done" button, it will close the entire screen, not just the keyboard.

We should add some more specific xpath to make sure we find the button on the keyboard toolbar.
@ctrevarthen ctrevarthen added bug Something isn't working ios This issue affects iOS labels Jul 29, 2019
@ctrevarthen ctrevarthen changed the title iOS: Closing keyboard doesn't account for multiple "Done" buttons Closing keyboard doesn't account for multiple "Done" buttons Jul 29, 2019
@ctrevarthen ctrevarthen added the in progress This issue is being worked on currently label Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working in progress This issue is being worked on currently ios This issue affects iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctrevarthen