-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to v2 API #30
Comments
Does it work until the end of WC2018? |
Yes, I think so. -> https://www.football-data.org/documentation/quickstart "The old v1 API will remain available for the foreseeable future, but I do recommend you migrate to the new v2 API ASAP. The v1 API documentation can still be accessed." |
World Cup 2018 should be fine. |
Any progress on this? |
I've made it compatible with v2, but I can't open a pull request to push my changes to repository, What should I do? @cmihaylov @davidus05 |
Great work, thanks! |
I'm idiot in git. Please fix it yourself. |
@aminvakil great work on the api v2 changes. I will review your pull request later today and merge it. |
So far I checked it on importing UCL matches only, maybe we should wait until the end of day and see what happens after games today and will we face any problem or not. @cmihaylov |
OK, cool. I'll try to validate it myself too if all works as expected. |
I did some minor fixes to the pull request and merged it. |
The API-provider https://www.football-data.org/ just changed to v2. So the old v1 version will be removed in the future.
A upgrade of the script would be great. Thanks!
The text was updated successfully, but these errors were encountered: