Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic versioning for titiler-cmr #26

Open
maxrjones opened this issue Aug 2, 2024 · 5 comments
Open

Dynamic versioning for titiler-cmr #26

maxrjones opened this issue Aug 2, 2024 · 5 comments

Comments

@maxrjones
Copy link
Member

For testing out caching mechanisms, it would be helpful to store the titiler-cmr version in test metadata, including the post-release information. I haven't used PDM for package management before, so I don't fully understand the setup. Does the current strategy require modifying the __version__ defined in titiler/cmr/__init__.py when a new tag is released? If so, would there be support for a modification to instead use dynamic versioning?

@maxrjones
Copy link
Member Author

cc @abarciauskas-bgse @vincentsarago

It looks like from a quick search most of the new titiler extensions use source = "file" for tool.pdm.version, but I couldn't find a repo with multiple tags to understand how subsequent release versions work.

@vincentsarago
Copy link
Member

every time we make a release in titiler-* module we update the __version__ variable in the __init__.py

workflow:

  • update version in __init__.py (usually using bump-my-version
  • create tags

as we never released titiler-cmr as an official package we never updated the version nor created tags.

@maxrjones
Copy link
Member Author

what's the motivation for using the static versioning? my experience has been that the extra metadata and lack of manual steps in dynamic versioning makes it worthwhile to use

@vincentsarago
Copy link
Member

I'm not sure to understand
Right now the titiler-cmr is set to use dynamic version (from the init file)

@maxrjones
Copy link
Member Author

I'm not sure to understand Right now the titiler-cmr is set to use dynamic version (from the init file)

Sorry, I wasn't clear in my original issue. Please see #27 for the specific proposal, which is to use dynamic versioning based on the git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants