Non terminating image check does not support parent in devfiles

[thepetk]

/kind bug

Which area is this bug related to?

/area ci
/area registry

Bug Summary

The check_non_terminating script is failing in case a registry stack is using a parent devfile.

Describe the bug:

As the devfile is not flattened before checking for non terminating images, the script is unable to find any components.

To Reproduce:

Create a registry stack that has only a metadata & parent section. An example is here:
https://github.com/devfile/registry/actions/runs/9259636857/job/25472255936?pr=401

Expected behavior

The check should be passing and the devfile should be flattened during the execution of the script with all the parent components.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Logs can be found here:
https://github.com/devfile/registry/actions/runs/9259636857/job/25472255936?pr=401

Testing /home/runner/work/registry/registry/stacks/ollama/devfile.yaml
  COMMAND: minikube ssh docker pull null

Additional context

Useful context is here: devfile/registry#401 (comment)

Any workaround?

N/A

Suggestion on how to fix the bug

N/A

[maysunfaisal]

One solution would be to invoking the devfile/library cmd and flattening the devfile before examining it. The devfile/library module might not have the flattening available via their main(), so we will need to update that main() a bit.

[AObuchow]

One solution would be to invoking the devfile/library cmd and flattening the devfile before examining it. The devfile/library module might not have the flattening available via their main(), so we will need to update that main() a bit.

+1 I think exposing this functionality might also be useful for future cases where we need to obtain the flattened version of a devfile easily

[github-actions]

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

[ibuziuk]

@thepetk hi, any ETA for this ?

[thepetk]

@thepetk hi, any ETA for this ?

Hi @ibuziuk ! The truth is it was left behind due to other priorities. I'm going to include it in the next sprint, so I'm aiming to have everything set mid-late february. Let me know if that works for you.

cc @elsony