Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize IngressClass name #1068

Open
gbonnefille opened this issue Mar 16, 2023 · 5 comments · May be fixed by #1070
Open

Parametrize IngressClass name #1068

gbonnefille opened this issue Mar 16, 2023 · 5 comments · May be fixed by #1070

Comments

@gbonnefille
Copy link
Contributor

Description

On a K3S kubernetes, the default ingress controller is traefik. It uses a "traefik" IngressClass.

Currently, the Ingress generated by devworkspace-controler is hardcoded to "nginx"

devworkspace-operator/controllers/controller/devworkspacerouting/solvers/basic_solver.go

Line 34 in 7e8aa72

"kubernetes.io/ingress.class": "nginx",

Having a parameter to control this name would help to reuse in different K8S.
@gbonnefille
Copy link
Contributor Author

gbonnefille commented Mar 16, 2023 •
edited
Loading

As a workaround, I created a nginx IngressClass to reroute to traefik

apiVersion: networking.k8s.io/v1
kind: IngressClass
metadata:
  name: nginx
spec:
  controller: traefik.io/ingress-controller

Traefik is now interested in the generated Ingresses but:

time="2023-03-16T16:32:11Z" level=error msg="Error while updating ingress status: failed to update ingress status default/workspace31cb5bbeca574a4d-che-code: Operation cannot be fulfilled on ingresses.networking
.k8s.io \"workspace31cb5bbeca574a4d-che-code\": the object has been modified; please apply your changes to the latest version and try again" namespace=default providerName=kubernetes ingress=workspace31cb5bbeca5
74a4d-che-code

I suspect a race condition around Status: traefik try to update and devworkspace-controller reconcille the Ingress.

devworkspace-controller {"level":"info","ts":"2023-03-16T16:32:38Z","logger":"controllers.DevWorkspaceRouting","msg":"Ingresses not in sync","Request.Namespace":"default","Request.Name":"routing-workspace31cb5bb
eca574a4d","devworkspace_id":"workspace31cb5bbeca574a4d"}                                                                                                                                                          
devworkspace-controller {"level":"info","ts":"2023-03-16T16:32:38Z","logger":"controllers.DevWorkspaceRouting","msg":"Reconciling DevWorkspaceRouting","Request.Namespace":"default","Request.Name":"routing-worksp
ace31cb5bbeca574a4d","devworkspace_id":"workspace31cb5bbeca574a4d"}                                                                                                                                                
devworkspace-controller {"level":"info","ts":"2023-03-16T16:32:38Z","logger":"controllers.DevWorkspaceRouting","msg":"Reconciling DevWorkspaceRouting","Request.Namespace":"default","Request.Name":"routing-worksp
ace31cb5bbeca574a4d","devworkspace_id":"workspace31cb5bbeca574a4d"}

@gbonnefille
Copy link
Contributor Author

Humh... the Status is supposed to be ignored

devworkspace-operator/pkg/provision/sync/diffopts.go

Line 91 in 7e8aa72

cmpopts.IgnoreFields(networkingv1.Ingress{}, "TypeMeta", "ObjectMeta", "Status"),

@gbonnefille
Copy link
Contributor Author

gbonnefille commented Mar 16, 2023 •
edited
Loading

I did some tries. I suspect something also introduce the field metadata.annotations.field.cattle.io/publicEndpoints. I don't know if this is the issue...
But it is supposed to be excluded as it is part of ObjectMeta.

@gbonnefille
Copy link
Contributor Author

gbonnefille commented Mar 17, 2023 •
edited
Loading

@amisevsk is it possible to disable adding the nginx related annotations by default?

Or, having a config routing.annotations with the following behavior:

  • if not set, use a actual code to automatically set some defaults
  • if set, do not set the default and only apply the specified ones.

@gbonnefille gbonnefille linked a pull request Mar 21, 2023 that will close this issue
Open
3 tasks
@amisevsk amisevsk mentioned this issue Jun 30, 2023
Open
@gbonnefille
Copy link
Contributor Author

Related to #1143

@amisevsk amisevsk mentioned this issue Jul 10, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow to configure specific annotations gbonnefille/devworkspace-operator
1 participant
@gbonnefille