Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup ESLint with a pre-commit hook using husky #20

Open
prateek3255 opened this issue Oct 1, 2020 · 7 comments · May be fixed by #72
Open

Setup ESLint with a pre-commit hook using husky #20

prateek3255 opened this issue Oct 1, 2020 · 7 comments · May be fixed by #72
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@prateek3255
Copy link
Collaborator

Create an ESLint and prettier config, and set up a pre-commit hook with husky and lin-staged.
@prateek3255 prateek3255 added enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Oct 1, 2020
@Kuljeet-123
Copy link

@prateek3255 Can I work on this issue??

@prateek3255
Copy link
Collaborator Author

Sure go ahead

@naman360
Copy link

naman360 commented Oct 1, 2020

Can I work on this?

@Satyam1203
Copy link

Is this done? If not,. I'm ready to take it up

shra1dhar added a commit to shra1dhar/react-copy-mailto that referenced this issue Oct 1, 2020
@shra1dhar
devfolioco#20 - Added setup for Eslint, prettier, lint-staged and husky
5bcde95
shra1dhar added a commit to shra1dhar/react-copy-mailto that referenced this issue Oct 3, 2020
@shra1dhar
Merge pull request #1 from shra1dhar/added-eslint-prettier-precommit-…
bdce4cf 
…husky-and-lint-stage

devfolioco#20 - Added setup for Eslint, prettier, lint-staged and husky
shra1dhar added a commit to shra1dhar/react-copy-mailto that referenced this issue Oct 3, 2020
@shra1dhar
Revert "devfolioco#20 - Added setup for Eslint, prettier, lint-staged…
8923df3 
… and husky"
shra1dhar added a commit to shra1dhar/react-copy-mailto that referenced this issue Oct 3, 2020
@shra1dhar
Merge pull request #2 from shra1dhar/revert-1-added-eslint-prettier-p…
e03e86f 
…recommit-husky-and-lint-stage

Revert "devfolioco#20 - Added setup for Eslint, prettier, lint-staged and husky"
@BhaveshSGupta BhaveshSGupta mentioned this issue Oct 10, 2020
Open
@BhaveshSGupta
Copy link

As this was available I tried to add that. But I am currently having issues with configuration. If any one could help how to solve it or even pass some references it would be helpful

@GuyKh
Copy link

GuyKh commented Oct 11, 2020

I can also try to work it out

@GuyKh GuyKh linked a pull request Oct 11, 2020 that will close this issue
Open
@GuyKh
Copy link

GuyKh commented Oct 11, 2020

Looks like done. @prateek3255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setup ESLint, Preetier and Husky Hook on commit GuyKh/react-copy-mailto
6 participants
@GuyKh @BhaveshSGupta @prateek3255 @Satyam1203 @naman360 @Kuljeet-123