Delete item #52
Draft
Delete item #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoHara42
reviewed
Feb 21, 2023
.env
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Environment variables declared in this file are automatically made available to Prisma. | |||
There was a problem hiding this comment.
don't commit this file
git rm --cached name_of_file
NoHara42
reviewed
Feb 21, 2023
tsconfig.json
Outdated
| "lib": ["dom", "dom.iterable", "esnext"], | ||
| "allowJs": true, | ||
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "noEmit": true, | ||
| "esModuleInterop": true, | ||
| "module": "esnext", | ||
| "module": "commonjs", |
There was a problem hiding this comment.
NoHara42
reviewed
Feb 21, 2023
src/pages/api/deleteItem.ts
Outdated
| if (err instanceof ZodError) { | ||
| response.status(400).send(`Wrong Data Sent =>${JSON.stringify(err)}`); | ||
| } else { | ||
| response.status(418).send("Something is wrong"); |
NoHara42
reviewed
Feb 21, 2023
src/pages/api/deleteItem.ts
Outdated
| ListID: null, | ||
| }, | ||
| }); | ||
| response.status(201).send("Removed Items"); |
There was a problem hiding this comment.
200 is more fitting here
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks going to change it to 200.
NoHara42
reviewed
Feb 21, 2023
src/pages/api/deleteItem.ts
Outdated
| id: id, | ||
| }, | ||
| data: { | ||
| ListID: null, |
There was a problem hiding this comment.
please use disconnect: true
instead of nulling the reference to the foreign key here.
https://www.prisma.io/docs/reference/api-reference/prisma-client-reference#disconnect
There was a problem hiding this comment.
working, thanks.
NoHara42
requested changes
Feb 21, 2023
|
Removed .env file succesfully and tsconfig problem |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Here is my solution for the issue 44 to delete items from a list without removing the item itself.
After creating a patch request, it does indeed removed the item.