This repository has been archived by the owner on May 12, 2023. It is now read-only.
accept a channel for bot conduct #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbwlkr
reviewed
May 3, 2018
scripts/conduct.js
Outdated
| // hubot conduct - Remind the channel about the devICT code of conduct | ||
|
|
||
| module.exports = (robot) => { | ||
| robot.respond(/(?:code(?: of)? )?conduct(?:\s?([#@][\w-]+))?/i, (msg) => { |
There was a problem hiding this comment.
If we aren't supporting DMs to a person then remove the @ from the regex
scripts/conduct.js
Outdated
| // None | ||
| // | ||
| // Commands: | ||
| // hubot conduct - Remind the channel about the devICT code of conduct |
There was a problem hiding this comment.
Please add an example of sending the conduct message to a particular channel
|
yay! I'm not sure how to actually test that it would send to the proper channel , but this partially came from an example and my regex capturing was working so I assume it's going to work lol |
blunket
force-pushed
the
ConductAcceptChannel
branch
from
163ad25 to
5362723
Compare
|
Is this still legit, or should we close it, being 2 years old now? |
|
I assume it'll still work. I figure the goal is just to allow someone to bot conduct a channel anonymously |
|
And when I said "I figure", that was before I realized there was an issue linked to this explaining just exactly that 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't do DMs, not sure how i'd do that.
switched to JS cause i'm more comfortable than i am in coffeescript
fix #35
just realized there's already a PR for this #55 woops :(