Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce dependencies.json for gradle and remove hardcoded dependency #991

Open
Tracked by #726
hohwille opened this issue Jan 27, 2025 · 1 comment · May be fixed by #1000
Open
Tracked by #726

Introduce dependencies.json for gradle and remove hardcoded dependency #991

hohwille opened this issue Jan 27, 2025 · 1 comment · May be fixed by #1000
Assignees
@hj-lorenz
Labels
dependency Tool dependencies (if tool A requires tool B) enhancement New feature or request gradle Gralde build tool urls ide-urls repo and related processes and features

Comments

@hohwille
Copy link
Member

hohwille commented Jan 27, 2025 •
edited
Loading

Introduce #991 dependencies.json for gradle and remove hardcoded dependency:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/gradle/Gradle.java

Lines 26 to 31 in 4f2e37b

@Override
protected void installDependencies() {
// TODO create gradle/gralde/dependencies.json file in ide-urls and delete this method
getCommandlet(Java.class).install();
}

Input can be found here:
https://gradle.org/install/#prerequisites

Example can be found here:
https://github.com/devonfw/ide-urls/blob/master/tomcat/tomcat/dependencies.json
@hohwille hohwille mentioned this issue Jan 27, 2025
Open
11 tasks
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jan 27, 2025
@hohwille hohwille changed the title Introduce dependencies.json for gradle and remove hardcoded dependency: IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/gradle/Gradle.java Lines 26 to 31 in 4f2e37b @Override protected void installDependencies() { // TODO create gradle/gralde/dependencies.json file in ide-urls and delete this method getCommandlet(Java.class).install(); } Introduce dependencies.json for gradle and remove hardcoded dependency Jan 27, 2025
@hohwille hohwille added enhancement New feature or request gradle Gralde build tool dependency Tool dependencies (if tool A requires tool B) urls ide-urls repo and related processes and features labels Jan 27, 2025
@hj-lorenz hj-lorenz moved this from 🆕 New to 🏗 In progress in IDEasy board Jan 27, 2025
@hj-lorenz
Copy link
Contributor

@hohwille
I created the dependencies.json for gradle by using the matrix in
https://docs.gradle.org/current/userguide/compatibility.html

Range of gradle versions: 2.0 - 8.10

In ide-urls we have
a) gradle versions from 0.7 - 8.12.1 and
b) java version from 8u302b08 - 23_37

So I decided that all gradle versions up to 4.3 (exclusively) need java version 8.0 and
that all gradle version from 8.10 or higher need java version 23.

Is this OK for you? Otherwise please let me know and give me your suggestion.

@jan-vcapgemini jan-vcapgemini mentioned this issue Jan 29, 2025
Open
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 30, 2025
@hj-lorenz
devonfw#991: Introduce dependencies.json for gradle
8f7fc17 
Fixes devonfw#991
Removed method "installDependencies
Added test-json dependencies.json
Added GradleTest and necessary resources
@hj-lorenz hj-lorenz linked a pull request Jan 30, 2025 that will close this issue
Open
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 30, 2025
@hj-lorenz
devonfw#991: Introduce dependencies.json for gradle
8f788de 
Fixes devonfw#991
Removed method "installDependencies
Added test-json dependencies.json
Added GradleTest and necessary resources
Changed permissions to git execute in files
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 31, 2025
@hj-lorenz
devonfw#991: devonfw#991: Introduce dependencies.json for gradle
d99b2a5 
Fixes devonfw#991
Removed url files that are not necessary any more.
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 31, 2025
@hj-lorenz
devonfw#991: devonfw#991: Introduce dependencies.json for gradle
0663be8 
Fixes devonfw#991
Removed url files that are not necessary any more.
Added necessary .gitkeepfiles
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 31, 2025
@hj-lorenz
devonfw#991: Introduce dependencies.json for gradle
0b7d6d7 
Fixes devonfw#991
Removed method "installDependencies
Added test-json dependencies.json
Added GradleTest and necessary resources
Changed permissions to git execute in files
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 31, 2025
@hj-lorenz
devonfw#991: devonfw#991: Introduce dependencies.json for gradle
782d9f0 
Fixes devonfw#991
Removed url files that are not necessary any more.
hj-lorenz added a commit to hj-lorenz/IDEasy that referenced this issue Jan 31, 2025
@hj-lorenz
devonfw#991: devonfw#991: Introduce dependencies.json for gradle
793f0b8 
Fixes devonfw#991
Removed url files that are not necessary any more.
Added necessary .gitkeepfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hj-lorenz hj-lorenz

Labels
dependency Tool dependencies (if tool A requires tool B) enhancement New feature or request gradle Gralde build tool urls ide-urls repo and related processes and features
Projects
IDEasy board
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#991: Introduce dependencies.json for gradle hj-lorenz/IDEasy
2 participants
@hohwille @hj-lorenz