-
Notifications
You must be signed in to change notification settings - Fork 12
check for organizer image files if they are claimed to exist #573
Comments
This likely should be extended to include speaker images, as well as sharing images (and some others that it hasn't occurred to me yet). |
Makes sense! |
i can help with that :) i'm tending to fail the build, but i think it's always better to ask when in doubt |
I am not sure we'd want to fail a build - I'd rather display a default image (which, if they don't like, they can replace). |
We wouldn't fail the build if they left off an image - we fail it if they enter an image in the config but then the image is not there (i.e., I specify So I vote for failing the build. It's an error that is being caught, so it should fail. |
yeah, if the image is not set at data/events/yyyy-city.yml the theme already uses a default image as far as i could see :) |
Expected behavior
If organizer images don't exist in the repo, don't try to show them (even if the config yml claims they exist).
Actual behavior
Broken images:
Reproduction Steps
Claim organizer image exists but don't put it in repo.
The text was updated successfully, but these errors were encountered: