Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_dashboard tests run in the main checks #23

Closed
cjrace opened this issue Feb 18, 2024 · 1 comment · Fixed by #41
Closed

Make test_dashboard tests run in the main checks #23

cjrace opened this issue Feb 18, 2024 · 1 comment · Fixed by #41
Labels
bug Something isn't working

Comments

@cjrace
Copy link
Contributor

cjrace commented Feb 18, 2024

Currently as noted in the README we can only run the shinytest2 tests on test_dashboard locally, we should work out how we merge them with the main testing infrastructure so they run on devtools::check().
@cjrace cjrace added the bug Something isn't working label Feb 18, 2024
@cjrace cjrace mentioned this issue Feb 18, 2024
Merged
@cjrace
Copy link
Contributor Author

cjrace commented Jul 19, 2024

Have a workaround for now that runs them in a separate GitHub action workflow in #41

@cjrace cjrace linked a pull request Jul 19, 2024 that will close this issue
Add branch install notes to readme (plus clean up) #41
Merged
@cjrace cjrace closed this as completed in #41 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add branch install notes to readme (plus clean up) dfe-analytical-services/dfeshiny
1 participant
@cjrace