Bugfix/cookies panels vignette #86
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -72,7 +72,7 @@ | |||
| expect_gt( | |||
| grep( | |||
| paste0( | |||
| "<a href=\"https://shiny.posit.co/\" target=\"_blank\" rel=\"noopener no", | |||
| "<a href=\"https://shiny.posit.co/\" class=\"govuk-link\" target=\"_blank\" rel=\"noopener no", | |||
Check notice
Code scanning / lintr
Lines should not be more than 100 characters. This line is 103 characters. Note test
| # Left navigation ========================================================= | ||
| shinyGovstyle::gov_box( | ||
|
|
||
| # fill = FALSE |
Check notice
Code scanning / lintr
Commented code should be removed. Note test
| ) | ||
|
|
||
| # shiny::observeEvent(input$`cookies_banner-cookies_link`, { | ||
| # bslib::nav_select("left_nav", selected = "cookies_panel") |
Check notice
Code scanning / lintr
Commented code should be removed. Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
Still a WIP... Latest notes to myself (this PR is not ready to review!):
Can use bslib::nav_select(), though bslib tab sets seem to work fine with shiny::updateTabsetPanel too, so that isn't the issue and is a nice thing for us meaning we can support bslib and not from the existing function in theory.
Clean up tasks to do before publishing / getting review
Why are these changes being made?
I tried to follow along with the existing vignette on the apps provider dashboard and couldn't successfully add cookies tracking into it.
Detailed description of changes
Coming soon
Additional information for reviewers
Coming soon
Issue ticket number/s and link
Resolves #53