Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using shinyGovstyle for the external_link() function #85

Open
cjrace opened this issue Jan 7, 2025 · 0 comments
Open

Move to using shinyGovstyle for the external_link() function #85

cjrace opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@cjrace
Copy link
Contributor

cjrace commented Jan 7, 2025

We've added external_link() into shinyGovstyle, so now it's time for dfeshiny to remove the code we have and instead just provide a wrapper around the code that's there, meaning we'll only need to update in one place moving forwards.

Will be a nice first example of something we've developed here and then has grown into a function that's used more widely than DfE so we've been able to pass on to shinyGovstyle instead while still protecting backwards compatibility.

@cjrace cjrace added the documentation Improvements or additions to documentation label Jan 7, 2025
@cjrace cjrace self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant