Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Majority of Colnect links aren't crawled at all #357

Open
6 tasks
dfernandezm opened this issue Nov 2, 2022 · 0 comments
Open
6 tasks

Majority of Colnect links aren't crawled at all #357

dfernandezm opened this issue Nov 2, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@dfernandezm
Copy link
Owner

dfernandezm commented Nov 2, 2022

Task

Lots of messages in logs of crawler job similar to the following:

[WARNING] Cannot find data in url https://colnect.com/en/banknotes/series/country/442-China

https://cloudlogging.app.goo.gl/rsYYxULnpgHepCbz5

For example: https://colnect.com/en/banknotes/series/country/17-Bahrain

Ideally a test should be written to avoid situations like this where many urls cannot be written. Checking the Cloud Storage bucket, what is in there is very few JSON files,

https://console.cloud.google.com/storage/browser/moneycol-import/colnect/01-11-2022?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=moneycol&prefix=&forceOnObjectsSortingFiltering=false

Acceptance criteria

  • All countries listed should be crawled properly

Definition of Done

    • Current tests pass
    • New tests added
    • Pull Request and self review
    • Clean build
    • Parent story linked
@dfernandezm dfernandezm added the bug Something isn't working label Nov 2, 2022
@dfernandezm dfernandezm added this to the 0.9.1 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant