Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should calibrate or redefine the factor 2.0 in get_r_inner for response calculations #26

Open
bast opened this issue Mar 9, 2018 · 2 comments

Comments

@bast
Copy link
Member

bast commented Mar 9, 2018

This possible problem was pointed out by @jaimeaxel.

https://github.com/dftlibs/numgrid/blob/master/numgrid/AtomGrid.cpp#L94-L95

@bast
Copy link
Member Author

bast commented Mar 9, 2018

The factor is hard-coded and may not be enough for response.

@bast
Copy link
Member Author

bast commented May 23, 2021

numgrid/src/radial.rs

Lines 80 to 81 in 319a80e

// factor 2.0 to match DIRAC code
let r_inner = get_r_inner(radial_precision, alpha_max * 2.0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant