Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit held cards from newly generated decks #38

Open
dgw opened this issue Mar 10, 2017 · 2 comments
Open

Omit held cards from newly generated decks #38

dgw opened this issue Mar 10, 2017 · 2 comments

Comments

@dgw
Copy link
Owner

dgw commented Mar 10, 2017

While working on #37 I had this thought: Why not omit cards that are out (in players' hands) from the generated deck?

Have to make a decision about how to handle cards that are held by players who left the game, because their cards are saved in case they rejoin (to prevent quit/join exploit for getting back down to 7). But it is trivial to go through the deck and remove each card held by every player, plus the top card on the discard pile.

@dgw
Copy link
Owner Author

dgw commented Mar 23, 2017

Maybe stop remembering the exact cards of players who leave, and just store the number of cards they had? The point of that feature is to block the quit/join hack to get back to 7 cards after being hit by several penalties, but the actual card values aren't important. They're only used when the player rejoins, so that's the only place that would need changing (to draw new cards instead of just using what was saved).

@dgw
Copy link
Owner Author

dgw commented Mar 16, 2019

Was looking through issues in Jenni (part of Sopel's lineage) and found possible inspiration for a patch addressing this issue in myano/jenni#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant