Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2dns): add partial support for SOA records #1295

Open
3 of 4 tasks
dhiaayachi opened this issue Sep 28, 2024 · 0 comments
Open
3 of 4 tasks

feat(v2dns): add partial support for SOA records #1295

dhiaayachi opened this issue Sep 28, 2024 · 0 comments

Comments

@dhiaayachi
Copy link
Owner

Description

This PR adds partial support for SOA records. SOA records are return in these cases:

  • When an SOA query type is used. Nameservers are also provided in this case.
  • When there is a valid query name but no data to return.

The necessary code paths for this record type are implemented, but not the fetching of nameservers, which will come in a subsequent PR.

Testing & Reproduction steps

  • Unit tests are added with mock QueryProcessors
  • V1 DNS tests - there weren't any to enable here. They all involve hitting the catalog in one way or another.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhiaayachi