Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determining Makam by comparing Teslim accidentals #7

Open
Tracked by #5
JusticeV452 opened this issue May 2, 2023 · 0 comments
Open
Tracked by #5

Determining Makam by comparing Teslim accidentals #7

JusticeV452 opened this issue May 2, 2023 · 0 comments
Assignees

Comments

@JusticeV452
Copy link
Member

Another way we can infer the Makam of the Teslim is by checking the similarity in the types of accidentals in the Teslim and each Makam example in Makam List for One Key Signature.mscz

The accidentals in a Sarki's Teslim and the accidental in the Makam examples can be extracted using extract_teslim_info and find_maqams from find_teslim.ipynb. The dictionary returned from find_makams should contain a map of Makam to another dictionary containing a list of possible accidentals. Should the Teslim accidentals from a Sarki significantly match (high percent of accidentals in common) any of the accidentals corresponding to a Makam, it should be considered more likely to be in that Makam.

As this will be one of the functions used in our standardized tester, it should:

  • take in a music21 Stream and a list of possible Makams (strings) for the Teslim
  • return a list of Makams (strings) in the order of most closely matching the Teslim to least closely matching the Teslim. In this case, "most closely matching the Teslim" is determined by the highest percentage of accidentals in common with the Teslim.
    (The returned Makams of these functions should be a subset of the input list of possible Makams)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant