Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 30 skipped tests after all dependencies are installed and released correctly #90

Open
bobleesj opened this issue Sep 26, 2024 · 4 comments

Comments

@bobleesj
Copy link

30 tests are skipped when pyobjcryst, diffpy.structure, diffpy.srreal, sas are not installed.

Current result without installing the dependencies mentioned above:

conda create -n diffpy.srfit_312 python=3.12
conda activate diffpy.srfit_312
pip install -r requirement/run.txt  # scipy, numpy, matplotlib (at the moment)
pip install . --no-deps
pytest

====== 80 passed, 30 skipped, 1 warning in 0.43s =====
@sbillinge
Copy link
Contributor

I think we don't want to skip these, so we just have CI install these things?

@bobleesj
Copy link
Author

yes we don't want to, while we re-cookiecut, i will add these dependencies under run.txt and see what happens.

@bobleesj
Copy link
Author

Discussed with @sbillinge in #89

  • include optional dependencies such as diffpy.structure under run-ext.txt

@sbillinge sbillinge reopened this Sep 30, 2024
@sbillinge
Copy link
Contributor

reopening. Let's close when it is merged into main and fully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants