Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uci doesn't like dashes in section names #22

Open
perbu opened this issue Jan 4, 2024 · 3 comments
Open

uci doesn't like dashes in section names #22

perbu opened this issue Jan 4, 2024 · 3 comments

Comments

@perbu
Copy link
Contributor

perbu commented Jan 4, 2024

Hi.

I noticed that the parser is a bit more relaxed than the uci parser in OpenWRT. Would you be interested in a patch that would fail is we see something other than a-z, A-Z, 0-9 or "_"?

@relet made me aware of this.

@perbu
Copy link
Contributor Author

perbu commented Jan 4, 2024

(this would naturally be only relevant for the v2 branch)

@perbu
Copy link
Contributor Author

perbu commented Jan 4, 2024

There is an issue on this; #8, which we might address at the same time.

@dmke
Copy link
Member

dmke commented Jan 4, 2024

As hinted in #8, go-uci ought to try its best to mimic the behaviour of uci itself (i.e. if uci parses "wifi-device", so should go-uci). Keep that in mind when rectifying the parser :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants