Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Number Relation #142

Open
Ben-Hodgkiss opened this issue Oct 31, 2024 · 0 comments
Open

Entity Number Relation #142

Ben-Hodgkiss opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request Providers Dependency Providers are dependant on this work

Comments

@Ben-Hodgkiss
Copy link
Contributor

Ben-Hodgkiss commented Oct 31, 2024

Overview
The Providers team would like to be able to use entity numbers when creating issues. This will mean that the entity assignment needs to be moved in the pipeline to an earlier stage. @eveleighoj has begun some research on this and believes it is possible!

Pull Request(PR):

Tech Approach

  • Issues are written at an entry level (technically an entry-field level) and given that each entry has to be provided an entity in order to turn it into a set of facts we should also be able to provide the entity in the issues table.
  • when an entity is not assigned an issue cannot be given an entity therefore it will be blank and should be able to be blank.

There are two main approaches to do this:

  • at the entity assignment stage retrospectively apply entity numbers to all issues from that entry. This could be difficult but would be the least impactful way. of doing it.
  • The log is stored in memory until the end of the process so can be retrospectively updated until that point.
  • move the entity assignment phase earlier in the process to attempt to assign an entity number before other issues are raised. You need to be careful on the order of the phases with this approach. E.g. The organisation phase has to happen before entity. assignment.

There are issues being assigned outside of the main pipeline that it's worth looking out for.

Acceptance Criteria/Tests

  • Each issue has a corresponding entity number
  • issues where the entry's entity is unknown don't have an entity number
  • minimal changes to which issues are raised.

Resourcing & Dependencies

  • Providers must be informed to test prior to implementation
  • DM should take a look too
@Ben-Hodgkiss Ben-Hodgkiss converted this from a draft issue Oct 31, 2024
@Ben-Hodgkiss Ben-Hodgkiss added enhancement New feature or request Providers Dependency Providers are dependant on this work labels Oct 31, 2024
@Ben-Hodgkiss Ben-Hodgkiss assigned eveleighoj and unassigned eveleighoj Nov 1, 2024
@cjohns-scottlogic cjohns-scottlogic pinned this issue Nov 6, 2024
@Ben-Hodgkiss Ben-Hodgkiss moved this from Refine, Prioritise & Plan to Sprint Backlog in Infrastructure Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Providers Dependency Providers are dependant on this work
Projects
Status: Deployment
Development

No branches or pull requests

3 participants