Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-test-renderer and rewrite tests #2746

Closed
steffenkleinle opened this issue Mar 27, 2024 · 1 comment · Fixed by #3062
Closed

Remove react-test-renderer and rewrite tests #2746

steffenkleinle opened this issue Mar 27, 2024 · 1 comment · Fixed by #3062
Assignees
@lunars97
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers Native Affects the native project not-testable Not testable by our tester ready Task Test

Comments

@steffenkleinle
Copy link
Member

steffenkleinle commented Mar 27, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
We still have two legacy tests using react-test-renderer in native.

Describe the solution you'd like

  • Rewrite the two tests (DashboardNavigationTiles.spec.tsx and SearchListItem.spec.tsx) using react native testing library
  • Remove react-test-renderer and @types/react-test-renderer dependencies (if possible, might be needed as peer dependency)

Describe alternatives you've considered
None.

Additional context
None.
@steffenkleinle steffenkleinle added good first issue Good for newcomers dependencies Pull requests that update a dependency file ready Task Test Native Affects the native project not-testable Not testable by our tester labels Mar 27, 2024
@LeandraH
Copy link
Contributor

React-test-renderer might be a peer dep of react testing library, but we can still remove our own dependencies :)

@LeandraH LeandraH moved this to Next Up in team-app Jan 27, 2025
@lunars97 lunars97 self-assigned this Jan 27, 2025
@lunars97 lunars97 moved this from Next Up to In Progress in team-app Jan 29, 2025
@lunars97 lunars97 mentioned this issue Jan 29, 2025
Merged
@steffenkleinle steffenkleinle moved this from In Progress to In Review in team-app Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in team-app Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunars97 lunars97

Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers Native Affects the native project not-testable Not testable by our tester ready Task Test
Projects
team-app
Status: Done
Milestone
No milestone
3 participants
@LeandraH @steffenkleinle @lunars97