Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace poi_instance = POI.objects.filter(id=None).first() with None #3359

Open
MizukiTemma opened this issue Jan 22, 2025 · 0 comments
Open

Replace poi_instance = POI.objects.filter(id=None).first() with None #3359

MizukiTemma opened this issue Jan 22, 2025 · 0 comments
Labels
effort: low Should be doable in <4h enhancement This improves an existing feature good first issue Good for newcomers
Milestone
Backlog

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Jan 22, 2025 •
edited
Loading

Motivation

There is no object with id=None and poi_instance is always None. See this

Proposed Solution

Replace with None

Alternatives

User Story

Additional Context

This was found in this review

Design Requirements

Related Issues
@MizukiTemma MizukiTemma added the feature New feature or request label Jan 22, 2025
@MizukiTemma MizukiTemma mentioned this issue Jan 22, 2025
Merged
@charludo charludo added good first issue Good for newcomers effort: low Should be doable in <4h labels Jan 22, 2025
@JoeyStk JoeyStk added this to the Backlog milestone Jan 28, 2025
@JoeyStk JoeyStk added enhancement This improves an existing feature and removed feature New feature or request labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Should be doable in <4h enhancement This improves an existing feature good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@charludo @JoeyStk @MizukiTemma