You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
registry_name should not be required (and should probably not be an attribute)
Actual Behavior
registry_name is documented as required
Steps to Reproduce
We can test this by entering the name of a container registry of a different DigitalOcean Team (or presumably a non-existent registry, though i haven't tested this), and view the Docker credential API token instead being added to the Team associated with the API token used by the DigitalOcean Terraform provider.
Thanks for this write up! You're correct, the API does not require registry_name, so the provider should not either. Will update the provider as soon as we can. Also, thanks for the feedback on documentation- we will update that as well.
Spent some time looking at this and it's unfortunately not as easy as a fix as I'd hope without introducing a breaking change. Will need to put some more time/thought into it. Will add it to our backlog and prioritize when we have more capacity as it's not a blocking bug. More than happy to review a PR from the community if you'd like to see it resolved more quickly!
Bug Report
Describe the bug
The documentation and resource for
container_registry_docker_credentials
states thatregistry_name
is a required attribute.However, the API does not require it: https://docs.digitalocean.com/reference/api/digitalocean/#tag/Container-Registry/operation/registry_get_dockerCredentials (presumably because it can be implied, as there can only be one registry per DigitalOcean Team.)
Additionally, the documentation could be improved by making the relationship between Team (implied by the API token) and a Registry clear.
Affected Resource(s)
Expected Behavior
registry_name
should not be required (and should probably not be an attribute)Actual Behavior
registry_name
is documented as requiredSteps to Reproduce
We can test this by entering the name of a container registry of a different DigitalOcean Team (or presumably a non-existent registry, though i haven't tested this), and view the Docker credential API token instead being added to the Team associated with the API token used by the DigitalOcean Terraform provider.
Terraform Configuration Files
Terraform version
Debug Output
Panic Output
Additional context
Important Factoids
References
The text was updated successfully, but these errors were encountered: