Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php-lint-all doesn't identify problematic files, only that there were some #18

Open
posita opened this issue Sep 22, 2021 · 0 comments · May be fixed by #19
Open

php-lint-all doesn't identify problematic files, only that there were some #18

posita opened this issue Sep 22, 2021 · 0 comments · May be fixed by #19

Comments

@posita
Copy link

posita commented Sep 22, 2021

Config:

# .pre-commit-config.yaml
repos:
  - repo: meta
    hooks:
    - id: check-hooks-apply
    - id: check-useless-excludes
  - repo: https://github.com/digitalpulp/pre-commit-php.git
    rev: 1.4.0
    hooks:
    - id: php-lint-all

Output:

% pre-commit run --verbose --all-files
Check hooks apply to the repository......................................Passed
- hook id: check-hooks-apply
- duration: 0.44s
Check for useless excludes...............................................Passed
- hook id: check-useless-excludes
- duration: 0.41s
PHP Syntax Check (Comprehensive).........................................Failed
- hook id: php-lint-all
- duration: 7.74s
- exit code: 1

Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
Begin PHP Linter
────────────────────────────────────────────────────────────────────────────────
2 PHP Parse error(s) were found!
────────────────────────────────────────────────────────────────────────────────
Begin PHP Linter
Begin PHP Linter
────────────────────────────────────────────────────────────────────────────────
1 PHP Parse error(s) were found!
────────────────────────────────────────────────────────────────────────────────
Begin PHP Linter

It seems like it would be much more useful if the source of the errors were listed.
posita added a commit to posita/pre-commit-php that referenced this issue Sep 22, 2021
@posita
Print offending files with php-lint
7443c13 
Fixes digitalpulp#18.
Includes some minor `README.md` cleanup.
@posita posita linked a pull request Sep 22, 2021 that will close this issue
Open
posita added a commit to posita/pre-commit-php that referenced this issue Sep 29, 2021
@posita
Print offending files with php-lint
a7940e0 
Fixes digitalpulp#18 and digitalpulp#22.
Includes some minor `README.md` cleanup.
posita added a commit to posita/pre-commit-php that referenced this issue Sep 30, 2021
@posita
Print offending files with php-lint
a71d9dd 
Fixes digitalpulp#18 and digitalpulp#22.
Includes some minor `README.md` cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print offending files with php-lint and accommodate paths with spaces posita/pre-commit-php
1 participant
@posita