Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write Aeson instances #23

Open
ericpashman opened this issue May 20, 2020 · 0 comments
Open

Re-write Aeson instances #23

ericpashman opened this issue May 20, 2020 · 0 comments

Comments

@ericpashman
Copy link
Collaborator

As I've noted previously, our Aeson instances should really implement the newer toEncoding(http://hackage.haskell.org/package/aeson-1.4.7.1/docs/Data-Aeson.html#v:toEncoding) interface, which is much faster than encoding via toJSON. We should be able to derive these generically with genericToEncoding in much the same way we've been using genericToJSON.

I also noticed as I was tracking down the test failures on the REST side of the library that there seem to be some hand-coded Aeson instances there that can be replaced with generically derived instances, much as we just did with the hand-coded instances I originally wrote for the WebSocket types.

These changes should be fairly straightforward. I'll try to get to them soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant