Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeOpen and beforeClose #54

Open
kouts opened this issue Jun 11, 2015 · 3 comments
Open

beforeOpen and beforeClose #54

kouts opened this issue Jun 11, 2015 · 3 comments

Comments

@kouts
Copy link

kouts commented Jun 11, 2015

Hi, great plugin, can you consider implementing beforeOpen and beforeClose callbacks in addition to onOpen and onClose?

Thanks.

@SnidelyWhiplash
Copy link

+1, although I believe the current onOpen is fired before the modal is shown. So actually that should be renamed to onBeforeOpen and the current onOpen should be fired after the animations are complete. The current onClose does seem to fire after animation is complete so we'd just need an onBeforeClose.

@SnidelyWhiplash
Copy link

Oh, I just saw your fork and pull request, would be great to get that in. :)

cc: @dinbror

@kouts
Copy link
Author

kouts commented Jul 11, 2015

Thanks @SnidelyWhiplash , I have also implemented an autoOpen option but I'm not sure if if have done it right. I hope that gets in too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants