Standard grep command fails on MacOS

[pandel]

Hi!

The perl style grep -ioP commands should be reworked. They don't work in MacOS anymore.

See: https://stackoverflow.com/questions/16658333/grep-p-no-longer-works-how-can-i-rewrite-my-searches

Regards,
Holger

[diogocavilha]

Hello, @pandel. Hope you're doing well.

Doesn't that work even if you brew install grep?

[pandel]

Hey @diogocavilha! I do and I hope, you too! Not too obvious these days...

That's a hint, I didn't try that. Usually I do not replace programs belonging to the main OS with other versions if I don't have to. The same is for sed, btw. It is also not working correctly.

But perhaps I'll replace them with the homebrew versions.

Thanks. I consider this as solved, even though I am not sure, if I'll use the brew versions or not ;-)

Perhaps you should give a hint in the installation section regarding installation of the brew versions on Mac...

[diogocavilha]

@pandel
Yes, things are getting harder lately.

You're right, I'll add this hint on readme file.
Please, let me know if any related bug shows up.

Thank you!

[diogocavilha]

Oh! I've just seen it is already there =D

Take a look... https://github.com/diogocavilha/fancy-git#problems-with-grep-command

[pandel]

Yes, you are right, I overlooked those entries, too :-)!

I did "brew install grep gnu-sed" right now and things are a bit more delicate, I think.

Both, grep and sed, are installed as "ggrep" and "gsed" to separate from the system default. Generally, I think it would be wise to keep this separation working instead of adding the necessary PATH changes.

Nevertheless, I'll add the PATH parts to my bash profile and see if it introduces any problems.

[pandel]

BTW, there is still a single error if you issue "fancygit" without any parameter:

/Users/myuser/.fancy-git/commands.sh: line 203: return: can only "return" from a function or sourced script

I am still using bash, not zsh! Just removed the "return" in the line and everything is fine, at least under Mac OS :-) - I don't think it is necessary on Linux either.

[diogocavilha]

BTW, there is still a single error if you issue "fancygit" without any parameter:

/Users/myuser/.fancy-git/commands.sh: line 203: return: can only "return" from a function or sourced script

I am still using bash, not zsh! Just removed the "return" in the line and everything is fine, at least under Mac OS :-) - I don't think it is necessary on Linux either.

Yes, it seems to be a Mac issue. I've tested it here and nothing happens.
Anyway, I'm gonna release this fix on next version, which is just around the corner! Thank you for that one!

Btw... could you please, open a new issue for that one?

[pandel]

Sure, here it comes: #69

[diogocavilha]

Sure, here it comes: #69

Thank you so much!