Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of adding additional prompt for showing current time #91

Closed
jtrupina opened this issue May 9, 2021 · 3 comments
Closed

Proposal of adding additional prompt for showing current time #91

jtrupina opened this issue May 9, 2021 · 3 comments

Comments

@jtrupina
Copy link
Contributor

jtrupina commented May 9, 2021

Many users (as well as me) like to have current time in terminal when running commands.

What about possibility that we extend this with another prompt but for current time and which should be configurable as well.

Currently, PS1 is defined like: PS1="${prompt_user}${prompt_symbol}${prompt_path} "

My proposal is to have something like this:

PS1="${prompt_time}${prompt_user}${prompt_symbol}${prompt_path} "

Then, we could have in app_config configured for example like this:

show-time: true
time-format: \D{%H:%M:%S}

If this proposal makes sense I'm more than glad to open PR for this.

@diogocavilha
Copy link
Owner

Hi @jtrupina

Thank you a lot for your suggestion.
I'll be happy to review your PR! Please submit it! Let's make Fancygit even better!

@jtrupina
Copy link
Contributor Author

@diogocavilha Here is the PR ready for review: #92

@diogocavilha
Copy link
Owner

Thanks @jtrupina.

I'm closing this thread once the feature has been merged already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants