Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with-dkml is not re-entrant #82

Open
jonahbeckford opened this issue Nov 28, 2023 · 0 comments
Open

with-dkml is not re-entrant #82

jonahbeckford opened this issue Nov 28, 2023 · 0 comments
Milestone
2.1.0

Comments

@jonahbeckford
Copy link
Contributor

jonahbeckford commented Nov 28, 2023 •
edited
Loading

During opam install, where opam.exe is a with-dkml.exe shim, opam can call ocaml (ex. ocaml gen_config_ml in the ocaml-system package).

But that ocaml is another with-dkml.exe shim, and prints the following during DKML_BUILD_TRACE=ON opam init ...:

ocamlc: [INFO] Running command: /usr/bin/env
                                  /Users/jonah/Applications/DkMLNative/bin/ocamlc-real
                                  -vnum
4.14.0

That unexpected output messes up the ocaml-system package, and will mess up other packages in hard-to-understand ways.
jonahbeckford added a commit to diskuv/dkml-runtime-apps that referenced this issue Nov 28, 2023
@jonahbeckford
bugfix: Both dkml/with-dkml need guards
7e6d181 
+ Do not set --yes when creating playground
>> Gives user the chance
to look at the build directory
on failures

diskuv/dkml-installer-ocaml#82
@jonahbeckford jonahbeckford added this to the 2.1.0 milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@jonahbeckford