diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..89002b66e --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,9 @@ +## PR Checklist (not all items are relevant to all PRs) + +- [] Added unit-tests (for runtime code) +- [] Added bootstrapped code + smoke tests (when the rendering logic is modified) +- [] Added build-plugins integration tests (when reflection loading is required at codegen-time) +- [] Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated) +- [] Updated dynamic module to match generated-code behaviour +- [] Added documentation +- [] Updated changelog diff --git a/CHANGELOG.md b/CHANGELOG.md index 8b9116ec3..962853ba0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ In 0.18.0, support was added for [open enums](https://disneystreaming.github.io/smithy4s/docs/codegen/customisation/open-enums) in smithy4s-generated code. This release extends that support to runtime (dynamic) schemas. +## Fixed a bug preventing a model pre-processor from being exercised + +This model-preprocessor aims at removing constraints from output types in AWS specs (as AWS doesn't seem to respect said constraints) +https://github.com/disneystreaming/smithy4s/pull/1251 + # 0.18.0 ## Behavioural changes diff --git a/modules/bootstrapped/resources/smithy4s.example.PizzaAdminService.json b/modules/bootstrapped/resources/smithy4s.example.PizzaAdminService.json index 20832679a..235999cb8 100644 --- a/modules/bootstrapped/resources/smithy4s.example.PizzaAdminService.json +++ b/modules/bootstrapped/resources/smithy4s.example.PizzaAdminService.json @@ -386,7 +386,8 @@ "headers": { "X-ADDED-AT": { "schema": { - "type": "number" + "type": "string", + "format": "epoch-seconds" }, "required": true } diff --git a/modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/build.sbt b/modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/build.sbt index b4882ed13..3e607fca3 100644 --- a/modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/build.sbt +++ b/modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/build.sbt @@ -10,7 +10,7 @@ lazy val root = (project in file(".")) val expectedLines = Set( "version", "src/main/smithy", - "com.disneystreaming.alloy:alloy-core:0.2.7" + "com.disneystreaming.alloy:alloy-core:0.2.8" ) val content = IO.readLines(baseDirectory.value / "smithy-build.json") diff --git a/modules/codegen-plugin/src/sbt-test/codegen-plugin/multimodule/build.sbt b/modules/codegen-plugin/src/sbt-test/codegen-plugin/multimodule/build.sbt index 19187f2df..c2c173aff 100644 --- a/modules/codegen-plugin/src/sbt-test/codegen-plugin/multimodule/build.sbt +++ b/modules/codegen-plugin/src/sbt-test/codegen-plugin/multimodule/build.sbt @@ -8,7 +8,7 @@ lazy val root = project "version", "src/main/smithy", "software.amazon.smithy:smithy-waiters:1.38.0", - "com.disneystreaming.alloy:alloy-core:0.2.7", + "com.disneystreaming.alloy:alloy-core:0.2.8", "com.disneystreaming.smithy4s:smithy4s-protocol:", "custom", "attribute" diff --git a/project/Dependencies.scala b/project/Dependencies.scala index edfb601f1..bce47b3a5 100644 --- a/project/Dependencies.scala +++ b/project/Dependencies.scala @@ -29,7 +29,7 @@ object Dependencies { val Alloy = new { val org = "com.disneystreaming.alloy" - val alloyVersion = "0.2.7" + val alloyVersion = "0.2.8" val core = org % "alloy-core" % alloyVersion val openapi = org %% "alloy-openapi" % alloyVersion val `protocol-tests` = org % "alloy-protocol-tests" % alloyVersion