From 151f369acb9ae78d2a381bc98ac15538c35d6f16 Mon Sep 17 00:00:00 2001 From: Matas Dailyda Date: Sat, 13 Jan 2018 15:47:46 +0200 Subject: [PATCH 1/2] Incorrect phone input type Fix incorrect phone input type - "phone" to correct - "tel", by specification https://www.w3schools.com/tags/att_input_type.asp --- aldryn_forms/cms_plugins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aldryn_forms/cms_plugins.py b/aldryn_forms/cms_plugins.py index 125e2c85..e71f5ec6 100644 --- a/aldryn_forms/cms_plugins.py +++ b/aldryn_forms/cms_plugins.py @@ -523,7 +523,7 @@ class HiddenField(BaseTextField): class PhoneField(BaseTextField): name = _('Phone Field') - form_field_widget_input_type = 'phone' + form_field_widget_input_type = 'tel' class NumberField(BaseTextField): From cd4a648a51ea72a095fc8b7f15ecdd9adfb10794 Mon Sep 17 00:00:00 2001 From: Matas Dailyda Date: Sat, 13 Jan 2018 16:18:10 +0200 Subject: [PATCH 2/2] Remove type attribute from textarea Remove unnecessary type attribute from TextAreaField, following the specification https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea --- aldryn_forms/cms_plugins.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/aldryn_forms/cms_plugins.py b/aldryn_forms/cms_plugins.py index 125e2c85..3fddb955 100644 --- a/aldryn_forms/cms_plugins.py +++ b/aldryn_forms/cms_plugins.py @@ -505,6 +505,8 @@ def get_form_field_widget(self, instance): def get_form_field_widget_attrs(self, instance): attrs = super(TextAreaField, self).get_form_field_widget_attrs(instance) + + del attrs['type'] if instance.text_area_columns: attrs['cols'] = instance.text_area_columns