Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further step for the porting instructions? #25

Open
philgyford opened this issue Feb 24, 2015 · 0 comments
Open

Further step for the porting instructions? #25

philgyford opened this issue Feb 24, 2015 · 0 comments

Comments

@philgyford
Copy link

Having just moved over to django-contrib-comments, I was really pleased that the instructions were so simple and it went so smoothly. Well done and thank you!

I had only one fatal error after following those instructions (using Django 1.7.4). I have an app that extends the comments app. The migration for this (there was only the 0001_initial.py migration) was like this:

# -*- coding: utf-8 -*-
from __future__ import unicode_literals

from django.db import models, migrations

class Migration(migrations.Migration):

    dependencies = [
        ('comments', '__first__'),
    ]

    operations = [
        migrations.CreateModel(
            name='Annotation',
            fields=[
            ],
            options={
                'proxy': True,
            },
            bases=('comments.comment',),
        ),
    ]

When starting the server I got:

    ...
    File "/Users/phil/.virtualenvs/django-pepysdiary/lib/python2.7/site-packages/django/db/migrations/loader.py", line 169, in check_key
        raise ValueError("Dependency on unknown app: %s" % key[0])
ValueError: Dependency on unknown app: comments`.

Changing the two instances of comments to django_comments in the above migration seems to have fixed the problem (at least, the server runs; I haven't tried any migrations). I'm not sure if that's the best solution, or if it's worth mentioning this kind of thing in the instructions? What would be the best fix if I had a history of migration files that depended on the comments app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant