Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting post_comment to Class Based views #82

Open
SudShekhar opened this issue Apr 17, 2016 · 3 comments
Open

Converting post_comment to Class Based views #82

SudShekhar opened this issue Apr 17, 2016 · 3 comments

Comments

@SudShekhar
Copy link

SudShekhar commented Apr 17, 2016 •
edited
Loading

Hi,

I was just wondering if there are any plans to migrate post_comment function to class based views? I am customizing django-contrib-comments to allow for file uploads and will need to copy paste the whole function. Was thinking that it would be much easier if we had the same thing as a class.

Any particular reason why it has not been done yet? Will pull requests for the same be welcome?

Thanks!
@claudep
Copy link
Member

claudep commented Apr 17, 2016

I also think that converting it to a class-based view would add value. So yes, patch welcome!

@SudShekhar
Copy link
Author

Cool. I will try to write the new view and create a patch over the coming weekend.

@claudep claudep mentioned this issue May 13, 2016
Closed
@claudep claudep mentioned this issue Oct 13, 2016
Open
@thomst thomst mentioned this issue Jul 13, 2021
Open
@thomst
Copy link

thomst commented Jul 13, 2021 •
edited
Loading

Just added a pull request #170 . A class based view would make customizing the view a lot more straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@claudep @thomst @SudShekhar