Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion object feature? #90

Open
yeago opened this issue May 11, 2016 · 3 comments
Open

Discussion object feature? #90

yeago opened this issue May 11, 2016 · 3 comments

Comments

@yeago
Copy link

yeago commented May 11, 2016

Would anyone be interested in a "Discussion object". It would be pluggable like Comments and you could attach things to it. The only thing I can imagine for now would be 'closed' discussions. Otherwise, its kind of awkward because you have to roll this same 'closed' feature into every app that may use comments (blogs, forums, etc)

@claudep
Copy link
Member

claudep commented May 11, 2016

You mean a mixin class? You can always try and show us some code, we'll see...

@yeago
Copy link
Author

yeago commented May 11, 2016

class Discussion(models.Model):
   object = GenericForeignKey()
   closed = models.BooleanField(default=False)

I'm thinking its just a parent class to hold attributes about an entire discussion. It links to a content object in the same way that comments do now. You would create one alongside your current content objects. From there, you could for example close discussions across types. If it was pluggable I could imagine people tacking on other attributes such as restricting access to discussions, etc.

@claudep
Copy link
Member

claudep commented May 12, 2016

The question is: would such a utility generic enough to warrant inclusion here? In any case, the way to go forward would be to implement it either in a project of yours or as another external app, and after that propose it for inclusion. It's very difficult to decide without a real implementation and at least one real use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants