Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feeds should only include items from approved feeds #1573

Closed
bmispelon opened this issue Jul 1, 2024 · 2 comments
Closed

RSS feeds should only include items from approved feeds #1573

bmispelon opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
bug python Pull requests that update Python code

Comments

@bmispelon
Copy link
Member

As reported in #1299 (comment), the RSS feeds (that is to say, the actual XML files) for the feeds on the community page (blog posts, jobs, packages, ...) include items for feeds that are not approved.

When listing items on the site (for example https://www.djangoproject.com/community/packages/), such items will be correctly excluded.

The RSS feeds (in aggregator/feeds.py) should be modified to also exclude un-approved feeds (and some tests should be added as well).

@bmispelon bmispelon added bug python Pull requests that update Python code labels Jul 1, 2024
@bmispelon bmispelon self-assigned this Jul 1, 2024
bmispelon added a commit to bmispelon/djangoproject.com that referenced this issue Jul 1, 2024
bmispelon added a commit to bmispelon/djangoproject.com that referenced this issue Jul 1, 2024
@bmispelon
Copy link
Member Author

@medmunds I've just deployed this change and the spam in the "new packages" feed should be gone now. Thanks again for pointing it out 👍🏻

@medmunds
Copy link

medmunds commented Jul 1, 2024

Much better. (I mean, still seven years out of date, but no more spam! 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants