In contact:addrType the elements sp and pc (contact::Address fields province and postal_code) are optional

[kmkaplan]

The elements sp, pc are optional but the struct Address in module contact makes them compulsory.

Here is the schema definition from RFC 5733, page 31

<complexType name="addrType">
  <sequence>
    <element name="street" type="contact:optPostalLineType"
     minOccurs="0" maxOccurs="3"/>
    <element name="city" type="contact:postalLineType"/>
    <element name="sp" type="contact:optPostalLineType"
     minOccurs="0"/>
    <element name="pc" type="contact:pcType"
     minOccurs="0"/>
    <element name="cc" type="contact:ccType"/>
  </sequence>
</complexType>

Should I fix this and submit PR?

This was originaly filed as masalachai/epp-client#96

[djc]

Yes, please!

[kmkaplan]

Ok, I'll start on monday.
Note that this will imply some API changes.

[djc]

Ok, I'll start on monday.

Note that this will imply some API changes.

That's not a problem. For our internal usage we're doing Git dependencies for now, we can put releases out if you have a need for that.