Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony.Commenting.FunctionComment.MissingParamTag should not complain if no params are documented and they are all typehinted #124

Closed
stof opened this issue Feb 6, 2018 · 3 comments
Closed

Symfony.Commenting.FunctionComment.MissingParamTag should not complain if no params are documented and they are all typehinted #124

stof opened this issue Feb 6, 2018 · 3 comments

Comments

@stof
Copy link
Contributor

stof commented Feb 6, 2018

If all arguments of the method are typehinted, duplicating the info in the phpdoc does not make sense.
currently, the sniff requires either adding all @param or removing the phpdoc entirely. But this second option forces to remove the description too.
@wickedOne
Copy link
Contributor

wouldn't this "break" ide info bubbles and phpdocumentor (i.e. not being completely useless)?

@stof
Copy link
Contributor Author

stof commented Mar 5, 2018

IDEs are able to read PHP typehints since years (they are even able to generate this phpdoc for you when you have a requirement to keep it).

and phpdocumentor also supports using the native typehints AFAIK.

@djoos
Copy link
Owner

djoos commented Sep 25, 2019

FYI: closing this one off - let's continue this issue in #120.

@djoos djoos closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wickedOne @stof @djoos