Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default shape no more #264

Open
ejiektpobehuk opened this issue Mar 12, 2020 · 3 comments
Open

Default shape no more #264

ejiektpobehuk opened this issue Mar 12, 2020 · 3 comments

Comments

@ejiektpobehuk
Copy link
Contributor

ejiektpobehuk commented Mar 12, 2020

Since this icon pack is not planning to support adaptive shapes (#229) I see no reason to force any.

There are a lot of icons in Circle shape for no particular reason (which contradicts the clean and simple goal of the project).

Examples: NewPipe, MAPS.ME, Twitter, Aurora Store/Services/Droid and many more.

Sometimes we just follow the lead of an original icon (Telegram is circle shaped), but sometimes it's just out of the blue (Twitter has just a bird while in frost it's caged in a Circle).

My proposal is to avoid any "background" shape until it's a central part of design (Yandex Taxi or MuPDF viever for example). In this case it can be an acceptance criteria.

@dkanada
Copy link
Owner

dkanada commented Mar 13, 2020

I agree completely! It can actually look worse when there's almost a common shape but not quite everywhere, so for this icon pack I would prefer to avoid common shapes whenever possible.

@ejiektpobehuk
Copy link
Contributor Author

To make this issue actionable and to bring definition of when it's complete I suggest to put "no default shape unit absolutely necessary" rule in contribution guide.

Not sure where exactly to put it and in what form.
While we are trying to be clear about our view on the topic it's necessary not to scare contributors off =]

@dkanada
Copy link
Owner

dkanada commented Mar 13, 2020

Feel free to put it wherever :) I haven't updated that guide in ages, and there are a lot of minor changes that would improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants