Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlliesShareVision game rule floods log with error #3572

Open
Loobinex opened this issue Oct 17, 2024 · 0 comments · May be fixed by #3571
Open

AlliesShareVision game rule floods log with error #3572

Loobinex opened this issue Oct 17, 2024 · 0 comments · May be fixed by #3571

Comments

@Loobinex
Copy link
Member

Start a game with the rule enabled and an active ally and find these log lines in keeperfx.log:

Error: players_are_mutual_allies: Tried to get non-existing player 9!

I investigated and it is because map_block_revealed function receives an ALL_PLAYERS (9). Reproduced it on 1.1 release version, probably been a bug since the introduction of the game rule.

#3571 stops the log, but I do not know if it is the proper fix for the root cause or if it causes more issues.

@walt253 walt253 linked a pull request Oct 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant