Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font.js is written in a non-strict mode #89

Open
jan-bw opened this issue Jul 6, 2023 · 1 comment
Open

font.js is written in a non-strict mode #89

jan-bw opened this issue Jul 6, 2023 · 1 comment

Comments

@jan-bw
Copy link

jan-bw commented Jul 6, 2023

Uncaught ReferenceError: assignment to undeclared variable WebFontConfig is being raised when importing the assets using the rails importmap with an old version (1.5.2). The fix is fairly simple - var needs to be added in front of the WebFontConfig in the fonts.js

I would open a PR, but there is no branch for the 1.5.2 :)

@dkniffin
Copy link
Owner

dkniffin commented Jul 6, 2023

@jan-bw I just created a v1 branch. You can create a PR against that.

Also, I've switched to using importmap-rails in my app too, but I've yet to switch AA assets. I want to get good support for it in here. That will probably be a v3 thing, because it will involve switching back to a gem, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants