Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Sensor Temperature #12

Open
fabi125 opened this issue Feb 16, 2021 · 1 comment
Open

Expose Sensor Temperature #12

fabi125 opened this issue Feb 16, 2021 · 1 comment

Comments

@fabi125
Copy link

fabi125 commented Feb 16, 2021

Hi there!

Right now the library only exposes the roomTemp, but sensors have a temperature as well.
In my case the roomTemp can only display 0.5 degree accuracy, whereas the sensor - at least seems - much preciser.

Mainly opening this FR to discuss what way you think this should be exposed (I'm happy to send a PR afterwards).

My simple idea would be to have get_current_temperature() return the sensor's temperature if available and then fall back to roomTemp. How does that sound?

Thanks!
Fabi

@dlarrick
Copy link
Owner

Sorry for the long-delayed response. Yes, since the sensor's temperature seems to be reported with greater precision I'd accept a small PR to return the sensor's temperature, if present, and fall back to the current method otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants