Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for optional role parameter in Names and Roles Provisioning Service #147

Open
FeldrinH opened this issue Aug 18, 2024 · 1 comment · May be fixed by #148
Open

Support for optional role parameter in Names and Roles Provisioning Service #147

FeldrinH opened this issue Aug 18, 2024 · 1 comment · May be fixed by #148

Comments

@FeldrinH
Copy link

FeldrinH commented Aug 18, 2024 •
edited
Loading

The Names and Roles Provisioning Service supports an optional role query parameter to filter members by role: https://www.imsglobal.org/spec/lti-nrps/v2p0#role-query-parameter.

It seems that the NamesRolesProvisioningService class in this library does not support this role parameter. It would be nice if this was supported. In some cases this filtering can make queries quite a bit faster. In one larger course in our Moodle the full get_members request takes about 500 ms to get all members, but only 200 ms to get all members with instructor role.
@FeldrinH
Copy link
Author

This should be a fairly simple change to NamesRolesProvisioningService.get_members.
@dmitry-viskov Would you be open to a PR?

@FeldrinH FeldrinH linked a pull request Aug 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for role parameter in NamesRolesProvisioningService FeldrinH/pylti1.3
1 participant
@FeldrinH