Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependencies on submakefiles #10

Open
mzemb opened this issue Dec 3, 2015 · 2 comments
Open

missing dependencies on submakefiles #10

mzemb opened this issue Dec 3, 2015 · 2 comments

Comments

@mzemb
Copy link

mzemb commented Dec 3, 2015

Hi there.

First, thanks for sharing your work. And good job as for code clarity: it's very readable in spite of make syntax not being that easy.

That said, I think that there is a design flaw: the targets do not depend on the submakefiles.
In your test-app, if I run make (to build all), and then I change something in one of the .mk files (say a -O0 in -O2), the next call to make outputs "nothing to be done" instead of rebuilding everything impacted by the option change.

I tried fixing it by introducing the name of the submakefile as fourth parameter to ADD_TARGET_RULE macro in order to add it to the dependencies, but I didn't succeed.

Can you fix that or suggest another way to come to the expected behaviour ?

Regards,

Michael

@igagis
Copy link

igagis commented Aug 27, 2016

The author seems silent. May I suggest https://github.com/igagis/prorab

@mzemb
Copy link
Author

mzemb commented Aug 30, 2016

It looks interesting. I'll take a deeper look the next time I invest time into the build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants