Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitLabelFXTest and SshPrivateKeyPasswordExistingFXTest fail inconsistently #621

Open
grenche opened this issue Jul 13, 2018 · 1 comment

Comments

@grenche
Copy link
Collaborator

grenche commented Jul 13, 2018

These two tests seem to fail inconsistently which makes me think they are probably related to threading errors.

@grenche
Copy link
Collaborator Author

grenche commented Jul 13, 2018

We think the issue in SshPrivateKeyPassworkExistingFXTest (and sometimes CloneSshFXTest in the commandLine folder) have to do with the fact that the ssh server is shut down before the thread is done running for repo monitor (documented in test as well). This is likely just a test bug, but a better solution would be good.

CommitLabelFXTest might be failing at the testAddFileAndCommit() -> doGitStatusWhenSubscribed() -> updateAllBranches -> refreshHeadIds -> refreshHeadIdsType() -> getHeadId() when getCommit() is called, but that hasn't been confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant