Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing google.golang.org/protobuf with github.com/protocolbuffers/protobuf-go #42

Open
nalzok opened this issue Dec 25, 2021 · 1 comment

Comments

@nalzok
Copy link

nalzok commented Dec 25, 2021

Hi there,

I am trying to package this repository to MacPorts (a package manager for macOS). Apparently, the tarballs from the domain google.golang.org/protobuf are not deterministic, so MacPorts doesn't support specifying dependencies with it. Can you replace google.golang.org/protobuf v1.23.0 with github.com/protocolbuffers/protobuf-go v1.23.0?

It would be extra awesome if you could cut a release after that, so that I have a release tag to pin.

... and Merry Christmas! 🎄

@cmikk
Copy link
Member

cmikk commented Dec 27, 2021

If I'm reading the MacPorts discussion correctly, it appears that this substitution occurs in the MacPorts Portfile, where the go import path google.golang.org/protobuf is fetched from the manually-specified path github.com/protocolbuffers/protobuf-go rather than the import path's default -- see lines 602-607 in the Portfile attached to the next MacPorts discussion comment.

Note that the GitHub path's contents include a go.mod file declaring the module with the google.golang.org/protobuf import path. This effectively prevents go get from fetching and recording dependencies on the GitHub path, which is why I suspect the deterministic download magic is happening within the MacPorts system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants