-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve documentation #6282
Comments
https://github.com/docker-library/faq#whats-the-difference-between-shared-and-simple-tags !! 😄
I'm not sure this is something we can add a generic limit for -- for example, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Per offline conversation with @tianon: Another good thing to clarify in the documentation would be inclusion criteria (i.e., "Is $project a good fit to be included in the library?"). |
Please take a look on this one to include that doc improvement docker-library/docs#2349 |
Since this appears to be a For awareness, per my support ticket, since 1.16 consul has updated the api path to manifests to be: The real issue for us here is that when these changes to how to retrieve It seems like we are missing a significant piece of the documentation and over the past few months we have run into multiple issues obtaining this data. For I would greatly appreciate any help/insight here. Also, not looking for manual steps. If we need to add some logic to check ahead of time somewhere, that is fine. |
@kcrane3576 I'm having a really hard time trying to understand what it is you're asking for, but it sounds like maybe you're having trouble understanding how to know if official images are deprecated / unsupported? Unfortunately, the best we can do with Docker Hub (where we publish our images) is a note on the image description. (Either way, this probably isn't on-topic for this issue, which is more about documentation about the official images program in general, and we don't have any APIs directly.) |
My apologies. I will try to explain the issue from my end a little better.
For awareness, the root goal for me is to always be able to pull the
`docker-content-digest` or Digest no matter what quirks are required within
the url.
Okay, so my understanding of dealing with 'Official Docker Images' is that
you have to amend the url to pull the manifests to include '/library/'.
So this:
curl "https://registry-1.docker.io/v2/$TARGET_NS_REPO/manifests/$TAG" \
-H "Authorization:Bearer $TOKEN" \
| jq '.fsLayers'
Based on my previous threads, this makes sense and non 'Official Docker
Images' are handled on more of a case by case basis.
Now I am being told instead of '/library/' for consul images, it has to be
'/hashicorp/'. Which would result in:
curl "
https://registry-1.docker.io/v2/hashicorp/$TARGET_NS_REPO/manifests/$TAG" \
-H "Authorization:Bearer $TOKEN" \
| jq '.fsLayers'
The information I would like to have is ALL of the other url amendment
requirements for Dockerhub Official Images.
- IF image is consul:
- THEN update url to be: "
https://registry-1.docker.io/v2/hashicorp/$TARGET_NS_REPO/manifests/$TAG"
- IF image is x:
- THEN update url to be: "
https://registry-1.docker.io/v2/{x_requirement}/$TARGET_NS_REPO/manifests/$TAG
"
…On Wed, Nov 29, 2023 at 7:27 PM Tianon Gravi ***@***.***> wrote:
@kcrane3576 <https://github.com/kcrane3576> I'm having a really hard time
trying to understand what it is you're asking for, but it sounds like maybe
you're having trouble understanding how to know if official images are
deprecated / unsupported? Unfortunately, the best we can do with Docker Hub
(where we publish our images) is a note on the image description.
(Either way, this probably isn't on-topic for this issue, which is more
about documentation about the official images program in general, and we
don't have any APIs directly.)
—
Reply to this email directly, view it on GitHub
<#6282 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARGWFTXEITFNHM6P47JDA3YG7HGPAVCNFSM4IB27F6KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBTGI4TCMJYGA4A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
My bad, the first curl reference should be:
So this:
curl "https://registry-1.docker.io/v2/library/$TARGET_NS_REPO/manifests/$TAG
<https://registry-1.docker.io/v2/$TARGET_NS_REPO/manifests/$TAG>" \
-H "Authorization:Bearer $TOKEN" \
| jq '.fsLayers'
Based on my previous threads, this makes sense and non 'Official Docker
Images' are handled on more of a case by case basis.
...
…On Wed, Nov 29, 2023 at 7:43 PM Kyle Crane ***@***.***> wrote:
My apologies. I will try to explain the issue from my end a little better.
For awareness, the root goal for me is to always be able to pull the
`docker-content-digest` or Digest no matter what quirks are required within
the url.
Okay, so my understanding of dealing with 'Official Docker Images' is that
you have to amend the url to pull the manifests to include '/library/'.
So this:
curl "https://registry-1.docker.io/v2/$TARGET_NS_REPO/manifests/$TAG" \
-H "Authorization:Bearer $TOKEN" \
| jq '.fsLayers'
Based on my previous threads, this makes sense and non 'Official Docker
Images' are handled on more of a case by case basis.
Now I am being told instead of '/library/' for consul images, it has to be
'/hashicorp/'. Which would result in:
curl "
https://registry-1.docker.io/v2/hashicorp/$TARGET_NS_REPO/manifests/$TAG"
\
-H "Authorization:Bearer $TOKEN" \
| jq '.fsLayers'
The information I would like to have is ALL of the other url amendment
requirements for Dockerhub Official Images.
- IF image is consul:
- THEN update url to be: "
https://registry-1.docker.io/v2/hashicorp/$TARGET_NS_REPO/manifests/$TAG"
- IF image is x:
- THEN update url to be: "
https://registry-1.docker.io/v2/{x_requirement}/$TARGET_NS_REPO/manifests/$TAG
"
On Wed, Nov 29, 2023 at 7:27 PM Tianon Gravi ***@***.***>
wrote:
> @kcrane3576 <https://github.com/kcrane3576> I'm having a really hard
> time trying to understand what it is you're asking for, but it sounds like
> maybe you're having trouble understanding how to know if official images
> are deprecated / unsupported? Unfortunately, the best we can do with Docker
> Hub (where we publish our images) is a note on the image description.
>
> (Either way, this probably isn't on-topic for this issue, which is more
> about documentation about the official images program in general, and we
> don't have any APIs directly.)
>
> —
> Reply to this email directly, view it on GitHub
> <#6282 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AARGWFTXEITFNHM6P47JDA3YG7HGPAVCNFSM4IB27F6KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBTGI4TCMJYGA4A>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
Thank you for your time,
Kyle Crane
***@***.***
|
Thanks for the clarification @kcrane3576 , hopefully I can do the same for you. The So when |
@whalelines If I am understanding correct, essentially consul will no longer a DOI after 1.16
Assuming I am correct, my question should be updated. Are there any DOI that don't follow the pattern of requiring
Again, my main goal here is to always be able to pull the docker-content-digest or Digest (for DOI). |
I appreciate the clarification above. This was exactly the information I needed.
|
Creating a catch-all issue so we can list areas for improvement.
SharedTags
: explain what they are and when they are usedlibrary
filealpine-pkg-glibc
or mixing of Alpine releases with Edge or other releases packages (Explicitly disallow the use of "alpine-pkg-glibc" #10794)rc
alias in image tags (generic pre-release marker): docker-library/docs #2349[software-version]-[variant]-[related-package-versions]-[os-version]
"Since every change of every image is reviewed by humans, one of the criteria is that new images are "reasonably popular" to be able to get the most out of the available time we have."
The text was updated successfully, but these errors were encountered: