Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support max-chunk-length for push imge #5589

Closed
harris2012 opened this issue Nov 1, 2024 · 1 comment
Closed

support max-chunk-length for push imge #5589

harris2012 opened this issue Nov 1, 2024 · 1 comment

Comments

@harris2012
Copy link

Description

considering someone is pushing a very large image like 2G.

Without the max-chunk-length.
any little network failure will let him patch whole image from 0%.

With the max-chunk-length.
He can patch the image every 30M. When networkle failure at 40%, he will continue to retry from 40%.

distribution-spec support the POST/PATCH/PUT method to push chunked image. if docker-cli support this, will be very useful.

@laurazard
Copy link
Member

laurazard commented Nov 12, 2024

Hi @harris2012, thanks for the report.

The Docker CLI is only a client for the Docker Engine (moby/moby), so this ticket is better suited for that repository. If the engine implements support for this feature, we'll make it available in the CLI.

Other than that though, there's an open issue in distribution/distribution to implement support for setting max chunk length when pushing – distribution/distribution#4144. While the impetus there is to support registries hinting the client as to what max chunk length to use, we'd likely want to see that discussion/implementation resolved before implementing support for this in the engine. There's ongoing discussion related to this in distribution-spec (here's a proposal – opencontainers/distribution-spec#485).


I'll close this for now, but feel free to open a ticket related to this in moby/moby if you'd like to continue the discussion.

@thaJeztah thaJeztah closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants