Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not a Contribution: credstore_env not a valid parameter to docker.from_env even though it is listed in docs #2627

Open
anorth2 opened this issue Jul 17, 2020 · 1 comment · May be fixed by #3314
Open

Not a Contribution: credstore_env not a valid parameter to docker.from_env even though it is listed in docs #2627

anorth2 opened this issue Jul 17, 2020 · 1 comment · May be fixed by #3314

Comments

@anorth2
Copy link

anorth2 commented Jul 17, 2020 •
edited
Loading

Not a Contribution!

docker_client = docker.from_env(credstore_env=credentials)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/...../docker/client.py", line 85, in from_env
    timeout=timeout, version=version, **kwargs_from_env(**kwargs)
TypeError: kwargs_from_env() got an unexpected keyword argument 'credstore_env'

https://docker-py.readthedocs.io/en/stable/client.html#docker.client.from_env
@anorth2
Copy link
Author

anorth2 commented Nov 18, 2020

Ping

@anorth2 anorth2 changed the title credstore_env not a valid parameter to docker.from_env even though it is listed in docs Not a Contribution: credstore_env not a valid parameter to docker.from_env even though it is listed in docs Nov 18, 2020
SmartManoj added a commit to SmartManoj/docker-py that referenced this issue Feb 28, 2025
@SmartManoj
Fix credstore_env parameter in docker.from_env
a4dcdeb 
Fixes docker#2627

* Retrieve `credstore_env` from the environment and add it to the `params` dictionary if it exists.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/docker/docker-py/issues/2627?shareId=XXXX-XXXX-XXXX-XXXX).
@SmartManoj SmartManoj linked a pull request Feb 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix credstore_env parameter in docker.from_env SmartManoj/docker-py
1 participant
@anorth2