Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tray icon colour (black rather than white) #14565

Open
EDIflyer opened this issue Jan 31, 2025 · 20 comments
Open

Wrong tray icon colour (black rather than white) #14565

EDIflyer opened this issue Jan 31, 2025 · 20 comments

Comments

@EDIflyer
Copy link

Description

Previous a white icon, since the latest update to 4.38..0 it is now black.

I note previous bug re icon colour - #4113 - not sure if a regression?

Image

Reproduce

Run Docker Desktop for Windows 4.38.0

Expected behavior

White icon on dark taskbar

docker version

Client:
 Version:           27.5.1
 API version:       1.47
 Go version:        go1.22.11
 Git commit:        9f9e405
 Built:             Wed Jan 22 13:41:44 2025
 OS/Arch:           windows/amd64
 Context:           desktop-linux

Server: Docker Desktop 4.38.0 (181591)
 Engine:
  Version:          27.5.1
  API version:      1.47 (minimum version 1.24)
  Go version:       go1.22.11
  Git commit:       4c9b3b0
  Built:            Wed Jan 22 13:41:17 2025
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.7.25
  GitCommit:        bcc810d6b9066471b0b6fa75f557a15a1cbf31bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e946
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Version:    27.5.1
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  ai: Ask Gordon - Docker Agent (Docker Inc.)
    Version:  v0.7.3
    Path:     C:\Program Files\Docker\cli-plugins\docker-ai.exe
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.20.1-desktop.2
    Path:     C:\Program Files\Docker\cli-plugins\docker-buildx.exe
  compose: Docker Compose (Docker Inc.)
    Version:  v2.32.4-desktop.1
    Path:     C:\Program Files\Docker\cli-plugins\docker-compose.exe
  debug: Get a shell into any image or container (Docker Inc.)
    Version:  0.0.38
    Path:     C:\Program Files\Docker\cli-plugins\docker-debug.exe
  desktop: Docker Desktop commands (Beta) (Docker Inc.)
    Version:  v0.1.4
    Path:     C:\Program Files\Docker\cli-plugins\docker-desktop.exe
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     C:\Program Files\Docker\cli-plugins\docker-dev.exe
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.27
    Path:     C:\Program Files\Docker\cli-plugins\docker-extension.exe
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.5
    Path:     C:\Program Files\Docker\cli-plugins\docker-feedback.exe
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.4.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-init.exe
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-sbom.exe
  scout: Docker Scout (Docker Inc.)
    Version:  v1.16.1
    Path:     C:\Program Files\Docker\cli-plugins\docker-scout.exe

Server:
 Containers: 4
  Running: 3
  Paused: 0
  Stopped: 1
 Images: 5
 Server Version: 27.5.1
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 CDI spec directories:
  /etc/cdi
  /var/run/cdi
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 nvidia runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: bcc810d6b9066471b0b6fa75f557a15a1cbf31bb
 runc version: v1.1.12-0-g51d5e946
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
 Kernel Version: 5.15.167.4-microsoft-standard-WSL2
 Operating System: Docker Desktop
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 7.617GiB
 Name: docker-desktop
 ID: 2b35e0d5-fc3e-408e-a2df-bc1ff9c1b6e9
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=npipe://\\.\pipe\docker_cli
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

WARNING: No blkio throttle.read_bps_device support
WARNING: No blkio throttle.write_bps_device support
WARNING: No blkio throttle.read_iops_device support
WARNING: No blkio throttle.write_iops_device support
WARNING: daemon is not using the default seccomp profile

Diagnostics ID

F5FC5563-1C07-4889-9998-5D2A7F63F50A/20250131110719

Additional Info

No response

@mark-dr
Copy link

mark-dr commented Jan 31, 2025

Thanks for the report! You're right, this looks like a regression. Could I ask you to check something in your Windows theming settings? In Settings -> Personalization -> Colors, do you have "Custom" for "Choose your mode"?

@EDIflyer
Copy link
Author

Thanks for the reply @mark-dr - yes, you're quite correct:

Image

IIRC I found Windows defaults a bit annoying for folders so have this custom setup!

@mark-dr
Copy link

mark-dr commented Jan 31, 2025

Thanks for the confirmation! Sounds like the icon's syncing with your app theme rather than your Windows mode - this usually happens if we're having trouble reading the registry for some reason. Sorry for the annoyance, I'll look into your diagnostic and get this fixed in our next version (4.39.0) 👍

@EDIflyer
Copy link
Author

Haha definitely just an annoyance rather than anything major but any little tweaks to fix much appreciated :)

@zoliszabo
Copy link

Happening to me too. Same settings in Personalization > Colors.

@lorand-horvath
Copy link

I confirm the issue, the tray icon is black on a black taskbar background, at first I didn't even notice it's there!
Please see below my Windows 10 settings under Personalization > Colors

Image

@iPilot
Copy link

iPilot commented Feb 6, 2025

It appears that icon is black when app theme is light and vice versa.

@andrey-helldar
Copy link

I also have the icon turned black after the last update.

Docker Desktop version is 4.38.0 (181591)
Windows 11

Mode: custom
Windows mode is dark
Apps mode is light
Transparency is on

Image
Image

@MikeWilliams-UK
Copy link

I am seeing this too on Windows 10 Professional

@koron
Copy link

koron commented Feb 8, 2025

I had the same issue on Win11.
However, after explicitly selecting Light in the Docker Desktop settings and restarting Docker Desktop, I got a white icon.

Image

@K2ouMais
Copy link

K2ouMais commented Feb 8, 2025

To turn the icon to white again you could change to dark mode Docker Desktop.

I am also using a light theme in Windows 11, but I like to have my Taskbar in dark.

The icon color problem is in Windows 10 and Windows 11.

@daniels1989
Copy link

Adding on to this: Have the same problem, same Windows settings as the users above (Custom colors, dark for Windows, light for apps), but I've set my Docker Desktop to use dark mode.
Docker Desktop boots on startup but minimizes to the system tray and since 4.38 uses the black icon as mentioned above. However when opening Docker Desktop for the first time since boot it briefly shows in light mode before swapping to dark mode, the icon changes to light mode at the same. This didn't happen in 4.37. So it seems as if the selected color scheme isn't updated until the window is actually opened.

@MikeWilliams-UK
Copy link

As the configuration of the windows theme of custom with light apps and dark task bar is the windows default.

Docker Desktop MUST use a sensible (white) task bar icon in that scenario.

@mark-dr
Copy link

mark-dr commented Feb 11, 2025

Hi folks, Docker engineer here. If you're experiencing this issue, could you try this build and let me know if it fixes it? Thanks!

@EDIflyer
Copy link
Author

EDIflyer commented Feb 11, 2025

@mark-dr weirdly it's looking OK just now on my system with my existing install (before trying the new build) - still 4.38.0 (181591), can't work out what changed?

@yastrebf
Copy link

@mark-dr Yes, your build 4.38 (182513) fixed this issue. Thank you

@K2ouMais
Copy link

@mark-dr your build works also for me. Thank you

@MikeWilliams-UK
Copy link

When will this build be avaible via the normal update route?

@mark-dr
Copy link

mark-dr commented Feb 11, 2025

@MikeWilliams-UK, I'll get it into the next scheduled release, planned to go live on Feb 27.

@MikeWilliams-UK
Copy link

Thanks @mark-dr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests